Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Extended Clipboard implementation issues #561

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Extended Clipboard implementation issues #561

wants to merge 3 commits into from

Commits on Mar 5, 2023

  1. libvncserver: Handle 'Z_STREAM_END' in zlib stream decompression 

    According to zlib manual (https://zlib.net/manual.htm):

"inflate() returns Z_OK if some progress has been made (more input processed or more output produced),
Z_STREAM_END if the end of the compressed data has been reached and all uncompressed output has been produced"
    @gujjwal00
    gujjwal00 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    9593244 View commit details
    Browse the repository at this point in the history

  2. libvncclient: Fix text length in extended clipboard encoding 

    Text data sent via extended clipboard encoding is null-terminated and this null character is counted in the length field sent to server.

E.g. for "abc", bytes  {'a', 'b', 'c', '\0'} are sent with length = 4.
    @gujjwal00
    gujjwal00 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    7ff0a53 View commit details
    Browse the repository at this point in the history

  3. libvncclient: Improve Extended Clipboard encoding compatibility 

    Many servers can't handle zlib streams created by compress() function
of zlib library. Primary bug is that these servers don't expect inflate()
to return Z_STREAM_END, which is the case for  streams created by
compress().

Affected servers:
LibVNCServer
UltraVNC
TigerVNC (<= 1.10)
    @gujjwal00
    gujjwal00 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    6adf8e2 View commit details
    Browse the repository at this point in the history