Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt Widgets example #612

Merged
merged 18 commits into from
Apr 3, 2024
Merged

Add Qt Widgets example #612

merged 18 commits into from
Apr 3, 2024

Conversation

nicmorais
Copy link
Contributor

@nicmorais nicmorais commented Mar 30, 2024

C++ was included as project language in CMakeLists.txt.
New WITH_QT option was created.
I couldn't build this example if the extension was .c, so I renamed it to .cpp. So I had to write specific CMake code to build this example almost apart from the others (see lines L672-L677).

Copy link

@dantti dantti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
examples/client/qt5client.cpp Outdated Show resolved Hide resolved
Copy link
Member

@bk138 bk138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice PR! Few minor comments/requests.

CMakeLists.txt Outdated Show resolved Hide resolved
examples/client/qt5client.cpp Show resolved Hide resolved
@bk138 bk138 self-assigned this Apr 2, 2024
@bk138 bk138 merged commit b44665c into LibVNC:master Apr 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants