fix: if an attribute is not required, allow it to not be set #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/notset_okay
branch
from
17cbba4
to
f8da7f5
Compare
JohnVillalovos
changed the title
JohnVillalovos
force-pushed
the
jlvillal/notset_okay
branch
from
f8da7f5
to
657ddb7
Compare
When using the API would get "Undefinedarray key" errors on missing custom attributes, even though those attributes were not required. Now allow the custom attribute to be missing if not a required custom attribute.
JohnVillalovos
force-pushed
the
jlvillal/notset_okay
branch
from
657ddb7
to
a08db74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the API would get "Undefinedarray key" errors on missing custom attributes, even though those attributes were not required.
Now allow the custom attribute to be missing if not a required custom attribute.