Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates.py: cleanup pass #301

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

antonlacon
Copy link
Contributor

This is a cleanup pass on updates.py. Some issues from reviewing it and some issues shown by pylint. Functional changes are converting Automatic Updates from a auto/manual selector to true/false and deleting custom channel 3. Info text for automatic updates also updated to reflect change.

The lchop/rchop changes means >=python-3.9, so no more support for LE10.

It's pulled the RPi2 LE11.0.0 -> 11.0.1 update for me. Other device testing appreciated.

@CvH
Copy link
Member

CvH commented Jun 3, 2023

@mglae can you have a look

General review and cleanup of issues pointed out by pylint:

unexpected indent
could use f-strings
not inializing variables in init
redefining builtins
too broad exceptions
unneeded elses after returns
unneeded parantheses
== instead of is in evaluating True/False
unused function parameters
unused imports

Signed-off-by: Ian Leonard <[email protected]>
Addon will require Python >=3.9

Signed-off-by: Ian Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants