Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger CI builds on master branch and pull requests #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rnestler
Copy link
Member

If we trigger on every branch we will have redundant CI runs for branches with pull requests.

@rnestler rnestler requested review from a team September 30, 2023 10:45
@rnestler rnestler self-assigned this Sep 30, 2023
@rnestler rnestler enabled auto-merge September 30, 2023 10:46
@ubruhin
Copy link
Member

ubruhin commented Sep 30, 2023

Hm actually I prefer getting CI feedback right on the first push of a new branch, without requiring to open a PR (yet) 🙈 IMHO the redundant CI runs are not a real problem as the runs are pretty fast, i.e. not wasting much time and resources...

@rnestler
Copy link
Member Author

rnestler commented Feb 8, 2024

Hm actually I prefer getting CI feedback right on the first push of a new branch, without requiring to open a PR (yet) 🙈 IMHO the redundant CI runs are not a real problem as the runs are pretty fast, i.e. not wasting much time and resources...

I was just annoyed by the 8 checks showing up. If I want CI I open a PR, if it's not ready yet I mark it as draft.

@rnestler rnestler force-pushed the avoid-redundant-ci-runs branch from e578ddf to c57c224 Compare February 8, 2024 16:29
@rnestler rnestler force-pushed the avoid-redundant-ci-runs branch from c57c224 to 5795416 Compare February 20, 2024 15:54
@rnestler rnestler requested a review from dbrgn February 20, 2024 15:54
If we trigger on every branch we will have redundant CI runs for
branches with pull requests.
@rnestler rnestler force-pushed the avoid-redundant-ci-runs branch from 5795416 to a4213fc Compare June 24, 2024 17:47
@rnestler rnestler disabled auto-merge June 24, 2024 17:47
@rnestler
Copy link
Member Author

I mean CI takes less then a minute in this project. If you want feedback before opening a PR you can run the tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants