-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added script for generating Pin Grid Array packages #72
Open
ouabache
wants to merge
3
commits into
LibrePCB:master
Choose a base branch
from
ouabache:pga
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added uuids for 3 pga packages
dbrgn
reviewed
Jan 18, 2020
@ouabache it seems that you added both PGA and BGA generators in this pull request. can you split them up? To revert the second commit, you can do:
|
I actually put two different scripts together. You should add both the bga
and pga ones.
…On Sat, Jan 18, 2020 at 1:44 PM Danilo Bargen ***@***.***> wrote:
@ouabache <https://github.com/ouabache> it seems that you added both PGA
and BGA generators in this pull request. can you split them up?
To revert the second commit, you can do:
git revert 1c7226b
git push
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72?email_source=notifications&email_token=AAKX3XGV7P4EU357IDHWOATQ6NZ5PA5CNFSM4KINNIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKCTWI#issuecomment-575941081>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKX3XF5NCBE4PL6GCCMS23Q6NZ5PANCNFSM4KINNIVA>
.
|
I'm confused... Didn't you add the BGA script in #67? |
I did create a b g a branch for the b g a script but have since added some
extra scripts for generating components from c v s files and kicad files.
Those will need some more work before they can be accepted.
The b g a script is near ready and I copied it into the fpga branch so we
can do both at the same time.
They are essentially the same script,all I need to do is lint them
…On Sun, Jan 19, 2020, 4:40 AM Danilo Bargen ***@***.***> wrote:
I'm confused... Didn't you add the BGA script in #67
<#67>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72?email_source=notifications&email_token=AAKX3XDIGVG5GN5LTL2M7K3Q6RC2HA5CNFSM4KINNIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKRFKA#issuecomment-576000680>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKX3XCENFK422OT4NQTYZ3Q6RC2HANCNFSM4KINNIVA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added uuids for 3 pga packages