[User Manual] Added example when less than 16cells are used. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jalinei
commented
Jun 11, 2024
jalinei
commented
- Added a different color for BMS power signals (first and last wires of the harness)
- Added a connection example for a 12s battery so that it is easier to understand how to wire the harness.
- Added a zoom view to explain what "exposed pads" refers to.
Minor change on main connection diagram, changed color on BMS supply
martinjaeger
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks @jalinei, that's a very nice improvement.
Only got a small remark to make sure the markdown is rendered correctly also for the PDF. (unfortunately, this is not yet generated in CI for PRs)
Co-authored-by: Martin Jäger <[email protected]>
|
[09bfa76] I've added this minor change to the PR. |
martinjaeger
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.