Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-22
to
+32
| if not all(field in data for field in expected_data): | ||
| if any(field not in data for field in expected_data): | ||
| return False, 'Invalid data format' | ||
|
|
||
| if data['Employment Type'] not in allowed_employment_types: | ||
| return False, 'Invalid Employment Type' | ||
|
|
||
| if data['Experience Level'] not in allowed_experience_levels: | ||
| return False, 'Invalid Experience Level' | ||
|
|
||
| #TODO: Add more checks like insurance it's within users country!!! | ||
|
|
There was a problem hiding this comment.
Function validate_job_data refactored with the following changes:
- Invert any/all to simplify comparisons (
invert-any-all)
Comment on lines
12
to
21
|
|
||
| # Create a signature | ||
| signature = private_key.sign( | ||
|
|
||
| return private_key.sign( | ||
| data, | ||
| padding.PSS( | ||
| mgf=padding.MGF1(hashes.SHA256()), | ||
| salt_length=padding.PSS.MAX_LENGTH | ||
| salt_length=padding.PSS.MAX_LENGTH, | ||
| ), | ||
| hashes.SHA256() | ||
| ) | ||
|
|
||
| # return signature.hex() #used this when I didn't have any default_backend code!!! | ||
| return signature No newline at end of file | ||
| hashes.SHA256(), | ||
| ) |
There was a problem hiding this comment.
Function sign_data refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# return signature.hex() #used this when I didn't have any default_backend code!!!
# Create a signature
|
|
There was a problem hiding this comment.
Function CompanyWorkflow.company_workflow refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
This removes the following comments ( why? ):
# NEW NEW NEW NEW
#! FAILS: If "Internal-Job-Listings" is the initial webpage this ruins
#TODO: refactor this!
Comment on lines
-442
to
+438
| language_of_webpage = predictions[0][0].replace('__label__', '') | ||
| #TODO: Determine whether this should go here or somewhere else!! | ||
| # if language_of_webpage == 'en': | ||
| # return True | ||
| # else: | ||
| # return False | ||
| # = = = = | ||
| # return language_of_webpage == 'en' | ||
| return language_of_webpage | ||
| return predictions[0][0].replace('__label__', '') |
There was a problem hiding this comment.
Function CompanyWorkflow.check_language_of_webpage refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# if language_of_webpage == 'en':
# = = = =
# return False
#TODO: Determine whether this should go here or somewhere else!!
# return True
# return language_of_webpage == 'en'
# else:
Comment on lines
-474
to
+463
| elements = { | ||
|
|
||
| return { |
There was a problem hiding this comment.
Function CompanyWorkflow.url_parser refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-1371
to
+1364
| if arg == 'greenhouse': | ||
| if arg in ['greenhouse', 'lever']: | ||
| print(method_name) | ||
| print(arg) | ||
| for key, value in kwargs.items(): | ||
| print(key + ": " + str(value)) | ||
| elif arg == 'lever': | ||
| print(method_name) | ||
| print(arg) | ||
| for key, value in kwargs.items(): | ||
| print(key + ": " + str(value)) | ||
| print(f"{key}: {str(value)}") |
There was a problem hiding this comment.
Function CompanyWorkflow.print_companies_internal_job_opening refactored with the following changes:
- Simplify conditional into switch-like form (
switch) - Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-1439
to
+1423
| if re.search(experience_needed, everything_about_job): | ||
| return False | ||
| else: | ||
| return True | ||
| return not re.search(experience_needed, everything_about_job) |
There was a problem hiding this comment.
Function CompanyWorkflow.should_user_apply refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Comment on lines
-1898
to
+1887
|
|
||
| if input_element.get('type') == 'radio': | ||
| label = self.find_radio_label(input_element) | ||
| return label | ||
|
|
||
| return self.find_radio_label(input_element) | ||
| if input_element.get('type') == 'checkbox': | ||
| div_parent, parents_text = self.get_div_parent(input_element) | ||
| if div_parent == 'None' or parents_text == 'None': | ||
| pass | ||
| elif div_parent and parents_text: | ||
| #return div_parent, parents_text | ||
| checkbox_values = [div_parent, parents_text] | ||
| return checkbox_values | ||
|
|
||
| return [div_parent, parents_text] |
There was a problem hiding this comment.
Function CompanyWorkflow.get_label refactored with the following changes:
- Use named expression to simplify assignment and conditional [×10] (
use-named-expression) - Inline variable that is immediately returned [×2] (
inline-immediately-returned-variable) - Use x is None rather than x == None (
none-compare) - Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
This removes the following comments ( why? ):
# Case 6: Check if the input_element has a placeholder attribute
#return div_parent, parents_text
Comment on lines
-2035
to
+2016
| if current_level == 0 or current_level == 5: | ||
| if current_level == 0: | ||
| print(element.prettify()) | ||
| if current_level == 5: | ||
| sauce = element.next_element.get_text(strip=True) | ||
| print(sauce) | ||
| return sauce | ||
| if current_level == 0: | ||
| print(element.prettify()) | ||
| elif current_level == 5: | ||
| sauce = element.next_element.get_text(strip=True) | ||
| print(sauce) | ||
| return sauce |
There was a problem hiding this comment.
Function CompanyWorkflow.find_radio_label refactored with the following changes:
- Hoist conditional out of nested conditional [×2] (
hoist-if-from-if) - Simplify conditional into switch-like form (
switch)
| print("Result #" + str(self.job_links_counter) + " from Google Seaech") | ||
| print(f"Result #{self.job_links_counter} from Google Seaech") |
There was a problem hiding this comment.
Function scraperGoogle.print_google_search_results refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Remove unnecessary calls to
str()from formatted values in f-strings (remove-str-from-fstring)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!