-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_bertscore_sorting
bug + validate idf arg
#2727
Conversation
test_bertscore_sorting
bug + validate idf arg
Sorry for the changes in the PR, some commits were meant for a separate branch (at this point, actually related to issue #2728 ). This one should be very basic. |
for more information, see https://pre-commit.ci
d0a5568
to
9fc79ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2727 +/- ##
========================================
- Coverage 69% 39% -30%
========================================
Files 329 316 -13
Lines 18083 17921 -162
========================================
- Hits 12505 7034 -5471
- Misses 5578 10887 +5309 |
What does this PR do?
Fixes a test related to
bert_score
sorting, added on: #2347Additionally, validates the
idf
input flag tobert_score
.Before submitting
📚 Documentation preview 📚: https://torchmetrics--2727.org.readthedocs.build/en/2727/