Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

ci: testing lightning & PL #7

Merged
merged 41 commits into from
Sep 2, 2023
Merged

ci: testing lightning & PL #7

merged 41 commits into from
Sep 2, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 2, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you all existing and newly added tests pass locally?

What does this PR do?

test for both packages Lightning & PL
fixes #34

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

@Borda Borda added the enhancement New feature or request label Mar 2, 2023
@Borda Borda requested a review from justusschock March 2, 2023 10:51
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #7 (0d2399e) into main (56c53b3) will decrease coverage by 1%.
The diff coverage is n/a.

Additional details and impacted files
@@        Coverage Diff         @@
##           main    #7   +/-   ##
==================================
- Coverage    58%   57%   -1%     
==================================
  Files         3     3           
  Lines       158   158           
==================================
- Hits         91    90    -1     
- Misses       67    68    +1     

@Borda Borda force-pushed the ci/pkgs branch 2 times, most recently from 6c100d7 to b313ea2 Compare March 7, 2023 22:12
@Borda
Copy link
Member Author

Borda commented Mar 8, 2023

Strange, 17 tests collected, running even CPU fails and process crashes...

requirements.txt Outdated Show resolved Hide resolved
@stale stale bot added the won't fix label May 21, 2023
@stale stale bot closed this Jun 18, 2023
@Borda Borda reopened this Jun 18, 2023
@Lightning-Universe Lightning-Universe deleted a comment from stale bot Jun 18, 2023
@mergify mergify bot added the has conflicts label Jul 3, 2023
@mergify mergify bot removed the has conflicts label Jul 17, 2023
@Borda
Copy link
Member Author

Borda commented Jul 17, 2023

failing to install with horovod/horovod#3744 (comment)

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #7 (daad4e3) into main (f4a9331) will decrease coverage by 1%.
The diff coverage is n/a.

Additional details and impacted files
@@        Coverage Diff         @@
##           main    #7   +/-   ##
==================================
- Coverage    59%   58%   -1%     
==================================
  Files         3     3           
  Lines       153   153           
==================================
- Hits         90    89    -1     
- Misses       63    64    +1     

@mergify mergify bot removed the has conflicts label Jul 17, 2023
@Borda Borda mentioned this pull request Sep 1, 2023
3 tasks
@mergify mergify bot added the has conflicts label Sep 2, 2023
@mergify mergify bot removed the has conflicts label Sep 2, 2023
tests/test_strategy_cuda.py Outdated Show resolved Hide resolved
@Borda Borda merged commit 1fb604e into main Sep 2, 2023
13 of 14 checks passed
@Borda Borda deleted the ci/pkgs branch September 2, 2023 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request won't fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant