Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: compatible with Lightning v2 #1094

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lannelin
Copy link

@lannelin lannelin commented Jun 7, 2024

What does this PR do?

Bumps to lightning 2 as per #1067

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://lightning-bolts--1094.org.readthedocs.build/en/1094/

@lannelin
Copy link
Author

lannelin commented Jun 7, 2024

I believe that some of the checks are failing for reasons unrelated to changes in this PR e.g. "Roms.rar is not RAR archive" in ubuntu-20.04, 3.8, latest.

I also haven't updated documentation as unsure where would be best to do so for this change.

@lannelin lannelin marked this pull request as ready for review June 7, 2024 08:44
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add description, I guess you try to bump dependency to lightning v2, right?

@lannelin
Copy link
Author

lannelin commented Jun 7, 2024

Pls add description, I guess you try to bump dependency to lightning v2, right?

Yes, sorry! I've updated it now.

@Borda Borda changed the title Lightning2 bump: compatible with Lightning v2 Jun 7, 2024
@RuRo
Copy link

RuRo commented Jul 5, 2024

Hi. @Borda can this PR be merged (and hopefully pushed to PyPI) or is there something blocking it?

The Roms.rar issue seems to be unrelated to this PR, but I think that it is caused by the fact that the curl commands in .azure/gpu-tests.yml and .github/workflows/ci-tests.yml use an outdated url http://www.atarimania.com/roms/Roms.rar that currently redirects to https://www.atarimania.com/roms/Roms.rar (https instead of http). It can be fixed either by adding the -L/--location flag to the curl commands or just changing the http to https.

@AElimrani
Copy link

Is there any other blocker here ? I saw that there was a merge requested but it never merged to this repo's main. I can help out if there are any other changes that are required or if anything is blocking the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants