-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to_review
flag
#835
Merged
Merged
to_review
flag
#835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaj
requested review from
edenlightning,
Borda,
ethanwharris and
awaelchli
as code owners
July 19, 2022 15:12
github-actions
bot
added
callback
datamodule
Anything related to datamodules
documentation
Improvements or additions to documentation
model
labels
Jul 19, 2022
Borda
approved these changes
Jul 19, 2022
akihironitta
approved these changes
Jul 20, 2022
Co-authored-by: Akihiro Nitta <[email protected]>
…olts into experiment_flag
I've decided to rename flag |
well, would be fine after this change reset review... :/ |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback
datamodule
Anything related to datamodules
documentation
Improvements or additions to documentation
model
ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the first step in reviving Bolts as outlined on Slack and #819 (comment)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃