Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of dataset normalizations #898

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Oct 6, 2022

What does this PR do?

Fixes part of #839

  • pl_bolts.transforms.dataset_normalizations
  • pl_bolts.tests.transforms.test_normalizations

Summary

  • Typing hints for each dataset normalization function
  • Tests for checking if normalizations return tensors of correct shape

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • N/A If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@matsumotosan matsumotosan changed the title Add tests for dataset normalization Revision of dataset normalizations Oct 6, 2022
@matsumotosan matsumotosan marked this pull request as ready for review October 6, 2022 17:32
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @matsumotosan, it looks good, thank you!

@otaj otaj enabled auto-merge (squash) October 11, 2022 08:57
@mergify mergify bot added the ready label Oct 11, 2022
@otaj otaj merged commit 7f8ede8 into Lightning-Universe:master Oct 11, 2022
@otaj otaj mentioned this pull request Oct 11, 2022
@matsumotosan matsumotosan deleted the dataset_normalizations branch October 11, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants