Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision datamodules...CityscapesDataModule #956

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

Revision datamodules...CityscapesDataModule #956

wants to merge 37 commits into from

Conversation

lijm1358
Copy link
Contributor

@lijm1358 lijm1358 commented Dec 29, 2022 •
edited
Loading

What does this PR do?

Related to #839

  • update docstring
  • add data type color, polygon along with torchvision cityscape
  • add train extra dataloader for coarse dataset
  • add color data type test

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Dec 29, 2022
@lijm1358 lijm1358 marked this pull request as ready for review December 29, 2022 12:06
@Borda Borda changed the title Revision pl_bolts.datamodules.cityscapes_datamodule.CityscapesDataModule Revision pl_bolts.datamodules.cityscapes_datamodule.CityscapesDataModule May 18, 2023
@Borda Borda changed the title Revision pl_bolts.datamodules.cityscapes_datamodule.CityscapesDataModule Revision datamodules...CityscapesDataModule May 18, 2023
@Borda Borda force-pushed the master branch 2 times, most recently from afdc09a to c5137b4 Compare May 19, 2023 17:15
@mergify mergify bot removed the has conflicts label May 19, 2023
@mergify mergify bot added ready and removed ready labels May 30, 2023
@Borda
Copy link
Member

Borda commented May 30, 2023

Let's bump min Python versiom, pending on #1021

@mergify mergify bot added ready and removed ready labels May 31, 2023
@Borda
Copy link
Member

Borda commented May 31, 2023

@lijm1358 could you pls check typing? 🐰

@mergify mergify bot added the ready label May 31, 2023
@mergify mergify bot added has conflicts and removed ready labels May 31, 2023
@mergify mergify bot removed the has conflicts label May 31, 2023
@mergify mergify bot added ready and removed ready labels Jun 8, 2023
@Borda Borda marked this pull request as draft June 16, 2023 18:18
auto-merge was automatically disabled June 16, 2023 18:18

Pull request was converted to draft

@dgcnz
Copy link

dgcnz commented Jul 4, 2024

Any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
datamodule Anything related to datamodules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lijm1358 @Borda @dgcnz