-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge submission! #10
Open
shpetimselaci
wants to merge
73
commits into
LimbicAI:main
Choose a base branch
from
shpetimselaci:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables validation
… queries, mutations
…hat, Added User queries resolvers, Commited PaginationParams type,
…sing dotenv/config
…r questions answers, and updated listUserAnswers to properly return needed properties
…or doing that, and auth?
…ire for creating a question
…eing reflected after action took place
…mented fully, edit just UI is there.
Feature/app mvp
Something that I wanted to address: |
Hey Shpetim,
Just a quick note: one of my team who is on mobile development may not be able to make it tomorrow, so I may have to move the meeting. I’ll find out in the morning since he’s off today.
Thanks for the understanding.
Aaron Hazelton
Full-Stack Developer
E: ***@***.*** ***@***.***) | W: www.limbic.ai (https://www.limbic.ai/)
The company accepts no liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided, unless that information is subsequently confirmed in writing. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.
… On Monday, Jul 01, 2024 at 6:53 PM, Shpetim Selaci ***@***.*** ***@***.***)> wrote:
Something that I wanted to address:
There are no unit tests :(
It took me a bit more time to do development on mobile, and I wanted to showcase my skills over there, rather than spending time doing unit/integration testing.
—
Reply to this email directly, view it on GitHub (#10 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAJBXNU6D4UW5ALATXQTIRLZKGCPLAVCNFSM6AAAAABKFV4CTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYZDEMBVGA).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Hey Aaron!
Please do it in advance!
Totally get it.
Best regards,
Shpetim Selaci | Software Engineer
On Tue, Jul 2, 2024 at 15:43 Aaron Hazelton ***@***.***>
wrote:
… Hey Shpetim,
Just a quick note: one of my team who is on mobile development may not be
able to make it tomorrow, so I may have to move the meeting. I’ll find out
in the morning since he’s off today.
Thanks for the understanding.
Aaron Hazelton
Full-Stack Developer
E: ***@***.*** ***@***.***) | W: www.limbic.ai (https://www.limbic.ai/)
The company accepts no liability for the content of this email, or for the
consequences of any actions taken on the basis of the information provided,
unless that information is subsequently confirmed in writing. If you are
not the intended recipient you are notified that disclosing, copying,
distributing or taking any action in reliance on the contents of this
information is strictly prohibited.
> On Monday, Jul 01, 2024 at 6:53 PM, Shpetim Selaci ***@***.***
***@***.***)> wrote:
>
> Something that I wanted to address:
> There are no unit tests :(
> It took me a bit more time to do development on mobile, and I wanted to
showcase my skills over there, rather than spending time doing
unit/integration testing.
>
>
> —
> Reply to this email directly, view it on GitHub (
#10 (comment)),
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAJBXNU6D4UW5ALATXQTIRLZKGCPLAVCNFSM6AAAAABKFV4CTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYZDEMBVGA).
> You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
>
>
>
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFRKLQ25JQQHCKKAMXN46FLZKKVBLAVCNFSM6AAAAABKFV4CTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTGIYDONZRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look at README.md on from the root directory and so on for guidance.
If you need help, just comment further on this thread!
Thank you for considering me for the position!
PS
App is only polished for iOS!
Best,
Shpetim