Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secp256k1 support #15

Merged
merged 30 commits into from
Jul 23, 2024
Merged

Secp256k1 support #15

merged 30 commits into from
Jul 23, 2024

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented May 7, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@gtsonevv gtsonevv requested a review from vikinatora May 7, 2024 10:06
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, other than that lgtm

"randombytes": "2.1.0"
"borsh": "1.0.0",
"randombytes": "2.1.0",
"secp256k1": "^5.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's lock the version of secp256k1

@@ -71,7 +71,7 @@
"files": [
{
"path": "dist/near-api-js.min.js",
"maxSize": "105kB"
"maxSize": "250kB"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

@gtsonevv gtsonevv merged commit cc93136 into master Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants