-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secp256k1 support #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, other than that lgtm
packages/crypto/package.json
Outdated
"randombytes": "2.1.0" | ||
"borsh": "1.0.0", | ||
"randombytes": "2.1.0", | ||
"secp256k1": "^5.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's lock the version of secp256k1
@@ -71,7 +71,7 @@ | |||
"files": [ | |||
{ | |||
"path": "dist/near-api-js.min.js", | |||
"maxSize": "105kB" | |||
"maxSize": "250kB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
Test Plan
Related issues/PRs