Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate lingmo-core to Qt6 #20

Merged
merged 25 commits into from
Dec 14, 2024
Merged

feat: Migrate lingmo-core to Qt6 #20

merged 25 commits into from
Dec 14, 2024

Conversation

elysia-best
Copy link
Contributor

@elysia-best elysia-best commented Nov 28, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Yes. With this pr merged, the library will need at least Qt6 to build. It will also need a Qt6 version of liblingmo

  • Other information:

@elysia-best elysia-best added the enhancement New feature or request label Nov 28, 2024
@elysia-best elysia-best self-assigned this Nov 28, 2024
@elysia-best elysia-best linked an issue Nov 28, 2024 that may be closed by this pull request
3 tasks
@elysia-best elysia-best requested a review from a team December 6, 2024 14:57
@elysia-best
Copy link
Contributor Author

It's time to merge this!

Bugs can be fixed later.

@elysia-best elysia-best marked this pull request as ready for review December 6, 2024 14:58
@elysia-best elysia-best marked this pull request as draft December 6, 2024 15:52
@elysia-best elysia-best marked this pull request as ready for review December 14, 2024 04:40
@elysia-best
Copy link
Contributor Author

@kodiakhq kodiakhq bot merged commit c4e4580 into main Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🚀 merge it!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Migration to Qt6
2 participants