[Feat/#242] 링크 이동, 최근 본 링크 구현 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmihye
reviewed
Oct 10, 2024
|
|
||
| import jakarta.validation.constraints.NotNull; | ||
|
|
||
| public record MoveToastDto(Long toastId, @NotNull Long categoryId) { |
There was a problem hiding this comment.
toastId는 NotNull 애노테이션 하지않은이유가 있을까요???
There was a problem hiding this comment.
전체 카테고리를 생각하다가 헷갈렸던 것 같네요..! toastId는 null이면 안될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
링크 이동과 최근 저장한 3개 링크 조회를 구현했습니다.
어떤 부분에 리뷰어가 집중해야 하는지
사실 최근에 리뷰를 받았는데 객체지향적으로 설계를 하려면 해당 객체에게 메시지로 명령을 해야하는 구조로 짜야될 것 같습니다! 여기서 추가적으로 리팩토링을 해보겠습니다!
개발하면서 어떤 점이 궁금했는지
예외 케이스는 추가적으로 없을지 봐주시면 좋을 것 같습니다!
그리고 url.. 좀 이쁘게 짜고싶은데 조언을 해주시면 같이 수정해보겠습니다.
🛠️ 테스트
🚀 API Endpoint