Refactor. Maybe something from that will be helpful

lua/scratch/api.lua

@@ -1,5 +1,4 @@
 local config = require("scratch.config")
-local slash = require("scratch.utils").Slash()
 local utils = require("scratch.utils")
 local telescope_status, telescope_builtin = pcall(require, "telescope.builtin")
 local MANUAL_INPUT_OPTION = "MANUAL_INPUT"
@@ -34,7 +33,7 @@ local function createScratchFileByName(filename)
   local scratch_file_dir = config_data.scratch_file_dir
   utils.initDir(scratch_file_dir)
 
-  local fullpath = scratch_file_dir .. slash .. filename
+  local fullpath = scratch_file_dir .. utils.slash .. filename
   create_and_edit_file(fullpath)
 end
 
@@ -205,8 +204,8 @@ local function open_scratch_vim_ui()
 
   -- sort the files by their last modified time in descending order
   table.sort(files, function(a, b)
-    return vim.fn.getftime(scratch_file_dir .. slash .. a)
-      > vim.fn.getftime(scratch_file_dir .. slash .. b)
+    return vim.fn.getftime(scratch_file_dir .. utils.slash .. a)
+      > vim.fn.getftime(scratch_file_dir .. utils.slash .. b)
   end)
 
   vim.ui.select(files, {
@@ -216,7 +215,7 @@ local function open_scratch_vim_ui()
     end,
   }, function(chosenFile)
     if chosenFile then
-      create_and_edit_file(scratch_file_dir .. slash .. chosenFile)
+      create_and_edit_file(scratch_file_dir .. utils.slash .. chosenFile)
       register_local_key()
     end
   end)

lua/scratch/config.lua

@@ -1,4 +1,3 @@
-local slash = require("scratch.utils").Slash()
 local utils = require("scratch.utils")
 
 ---@alias mode
@@ -44,7 +43,7 @@ local utils = require("scratch.utils")
 ---@field filetype_details Scratch.FiletypeDetails
 ---@field localKeys Scratch.LocalKeyConfig[]
 local default_config = {
-  scratch_file_dir = vim.fn.stdpath("cache") .. slash .. "scratch.nvim", -- where your scratch files will be put
+  scratch_file_dir = vim.fn.stdpath("cache") .. utils.slash .. "scratch.nvim", -- where your scratch files will be put
   filetypes = { "lua", "js", "py", "sh" }, -- you can simply put filetype here
   window_cmd = "edit", -- 'vsplit' | 'split' | 'edit' | 'tabedit' | 'rightbelow vsplit'
   file_picker = "fzflua",
@@ -74,7 +73,7 @@ local function get_abs_path(ft)
   local parentDir = config_data.scratch_file_dir
   local subdir = config_data.filetype_details[ft] and config_data.filetype_details[ft].subdir
   if subdir ~= nil then
-    parentDir = parentDir .. slash .. subdir
+    parentDir = parentDir .. utils.slash .. subdir
   end
   vim.fn.mkdir(parentDir, "p")
 

lua/scratch/telescope_actions.lua

@@ -32,7 +32,7 @@ function M.delete_item(prompt_bufnr)
     end
     local config_data = config.getConfig()
     local scratch_file_dir = config_data.scratch_file_dir
-    local p = Path:new({ scratch_file_dir, file_name, sep = utils.Slash() })
+    local p = Path:new({ scratch_file_dir, file_name, sep = utils.slash })
     return _delelte(p)
   end)
 end

lua/scratch/utils.lua

@@ -1,18 +1,19 @@
 local M = {}
 
-local function Slash()
-  local slash = "/"
-  if vim.fn.has("win32") == 1 then
-    slash = "\\"
-  end
-  return slash
-end
+-- NOTE: no need
+-- local function Slash()
+--   local slash = "/"
+--   if vim.fn.has("win32") == 1 then
+--     slash = "\\"
+--   end
+--   return slash
+-- end
 
-local slash = Slash()
+M.slash = vim.fn.has("win32") and "\\" or "/"
 
 -- Initialize the scratch file directory if it does not exist
 -- TODO: remove this function
-local function initDir(scratch_file_dir)
+function M.initDir(scratch_file_dir)
   if vim.fn.filereadable(scratch_file_dir) == 0 then
     vim.fn.mkdir(scratch_file_dir, "p")
   else
@@ -23,14 +24,14 @@ local function initDir(scratch_file_dir)
 end
 
 -- Recursively list all files in the specified directory
-local function listDirectoryRecursive(directory)
+function M.listDirectoryRecursive(directory)
   local files = {}
   local dir_list = vim.fn.readdir(directory)
 
   for _, file in ipairs(dir_list) do
-    local path = directory .. slash .. file
+    local path = directory .. M.slash .. file
     if vim.fn.isdirectory(path) == 1 and file ~= "." and file ~= ".." then
-      local subfiles = listDirectoryRecursive(path)
+      local subfiles = M.listDirectoryRecursive(path)
       for _, subfile in ipairs(subfiles) do
         files[#files + 1] = subfile
       end
@@ -47,18 +48,18 @@ end
 ---@param parentDir string
 ---@param requiresDir boolean
 ---@return string
-local function genFilepath(filename, parentDir, requiresDir)
+function M.genFilepath(filename, parentDir, requiresDir)
   if requiresDir then
     local dirName = vim.trim(vim.fn.system("uuidgen"))
-    vim.fn.mkdir(parentDir .. slash .. dirName, "p")
-    return parentDir .. slash .. dirName .. slash .. filename
+    vim.fn.mkdir(parentDir .. M.slash .. dirName, "p")
+    return parentDir .. M.slash .. dirName .. M.slash .. filename
   else
-    return parentDir .. slash .. filename
+    return parentDir .. M.slash .. filename
   end
 end
 
 ---@param localKeys Scratch.LocalKey[]
-local function setLocalKeybindings(localKeys)
+function M.setLocalKeybindings(localKeys)
   for _, localKey in ipairs(localKeys) do
     vim.keymap.set(localKey.modes, localKey.key, localKey.cmd, {
       noremap = true,
@@ -71,7 +72,7 @@ end
 
 ---@param substr string
 ---@return boolean
-local function filenameContains(substr)
+function M.filenameContains(substr)
   local s = vim.fn.expand("%:t")
   if string.find(s, substr) then
     return true
@@ -80,22 +81,24 @@ local function filenameContains(substr)
   end
 end
 
-local table_length = function(T)
-  local count = 0
-  for _ in pairs(T) do
-    count = count + 1
-  end
-  return count
-end
+-- local table_length = function(T)
+--   local count = 0
+--   for _ in pairs(T) do
+--     count = count + 1
+--   end
+--   return count
+-- end
 
 ---@return string[]
-local function getSelectedText()
+function M.getSelectedText()
   local _, csrow, cscol, _ = unpack(vim.fn.getpos("'<"))
   local _, cerow, cecol, _ = unpack(vim.fn.getpos("'>"))
-
+  --NOTE: perfomance eq but this always string[]
+  -- local lines = vim.api.nvim_buf_get_lines(0, csrow, cerow, false)
   local lines = vim.fn.getline(csrow, cerow)
-  local n = table_length(lines)
-  if n <= 0 then
+  ---@cast lines string[]
+  local n = #lines
+  if n == 0 then
     return {}
   end
   lines[n] = string.sub(lines[n], 1, cecol)
@@ -104,24 +107,27 @@ local function getSelectedText()
 end
 
 ---@param msg string
-local function log_err(msg)
+function M.log_err(msg)
   vim.notify(msg, vim.log.levels.ERROR, { title = "easy-commands.nvim" })
 end
 
 ---@param title string
 ---@return {buf: integer, win: integer}
-local function new_popup_window(title)
+function M.new_popup_window(title)
   local popup_buf = vim.api.nvim_create_buf(false, false)
-
+  -- NOTE: vim.api.nvim_get_option -- depracated
+  -- local api_get_option = vim.api.nvim_get_option or vim.api.nvim_get_option_value
   local opts = {
     relative = "editor", -- Assuming you want the floating window relative to the editor
     row = 2,
     col = 5,
-    width = vim.api.nvim_get_option("columns") - 10, -- Get the screen width
-    height = vim.api.nvim_get_option("lines") - 5, -- Get the screen height
+    --api_get_option("columns") - 10, (row * col?)
+    width = vim.api.nvim_win_get_width(0) - 10, -- Get the screen width
+    --api_get_option("lines") - 5,
+    height = vim.api.nvim_win_get_height(0) - 5, -- Get the screen height
     style = "minimal",
     border = "single",
-    title = ""
+    title = title,
   }
 
   local win = vim.api.nvim_open_win(popup_buf, true, opts)
@@ -130,15 +136,15 @@ local function new_popup_window(title)
     win = win,
   }
 end
-
-return {
-  Slash = Slash,
-  initDir = initDir,
-  listDirectoryRecursive = listDirectoryRecursive,
-  genFilepath = genFilepath,
-  setLocalKeybindings = setLocalKeybindings,
-  filenameContains = filenameContains,
-  getSelectedText = getSelectedText,
-  log_err = log_err,
-  new_popup_window = new_popup_window,
-}
+return M
+-- return {
+--   Slash = Slash,
+--   initDir = initDir,
+--   listDirectoryRecursive = listDirectoryRecursive,
+--   genFilepath = genFilepath,
+--   setLocalKeybindings = setLocalKeybindings,
+--   filenameContains = filenameContains,
+--   getSelectedText = getSelectedText,
+--   log_err = log_err,
+--   new_popup_window = new_popup_window,
+-- }