Fix icon for toggleable tools

LinwoodDev · Dec 31, 2024 · 8f09746 · 8f09746
1 parent 6e8e42b
commit 8f09746
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/app/lib/views/edit.dart b/app/lib/views/edit.dart
@@ -280,10 +280,7 @@ class _EditToolbarState extends State<EditToolbar> {
                                 ToolStatus.disabled
                             ? Theme.of(context).disabledColor
                             : null;
-                    var icon = handler.getIcon(bloc) ??
-                        tool.icon(selected
-                            ? PhosphorIconsStyle.fill
-                            : PhosphorIconsStyle.light);
+                    var handlerIcon = handler.getIcon(bloc);
                     final toolWidget = Padding(
                         padding: const EdgeInsets.symmetric(horizontal: 4.0),
                         child: OptionButton(
@@ -318,8 +315,16 @@ class _EditToolbarState extends State<EditToolbar> {
                                               PhosphorIconsLight.caretLeft,
                                           })
                                 : null,
-                            selectedIcon: _buildIcon(icon, size, color),
-                            icon: _buildIcon(icon, size, color),
+                            selectedIcon: _buildIcon(
+                                handlerIcon ??
+                                    tool.icon(PhosphorIconsStyle.fill),
+                                size,
+                                color),
+                            icon: _buildIcon(
+                                handlerIcon ??
+                                    tool.icon(PhosphorIconsStyle.light),
+                                size,
+                                color),
                             onPressed: () {
                               if (_mouseState == _MouseState.multi) {
                                 context

diff --git a/app/lib/widgets/option_button.dart b/app/lib/widgets/option_button.dart
@@ -60,7 +60,8 @@ class _OptionButtonState extends State<OptionButton>
   void didUpdateWidget(covariant OptionButton oldWidget) {
     super.didUpdateWidget(oldWidget);
     if (widget.selected != oldWidget.selected ||
-        widget.highlighted != oldWidget.highlighted) {
+        widget.highlighted != oldWidget.highlighted ||
+        widget.showBottom != oldWidget.showBottom) {
       setState(() {});
       _animationController.animateTo(_nextValue);
     }