Merge pull request #116 from nikolas-con/main

Fixed flickering
LiveDuo · Mar 12, 2024 · 6632e0b · 6632e0b
2 parents 0bb10b7 + 6f78950
commit 6632e0b
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/lib/client/vanilla/editor.tsx b/lib/client/vanilla/editor.tsx
@@ -309,8 +309,10 @@ function Editor({ standaloneServer = false }) {
 
     // update border
     const isTopHalf = isElementTopHalf(component, e)
-    component.style.setProperty(`border-${isTopHalf ? 'top' : 'bottom'}`, '4px solid cornflowerblue')
-    component.style.setProperty(`border-${!isTopHalf ? 'top' : 'bottom'}`, '')
+    component.style.setProperty(
+      'box-shadow',
+      isTopHalf ? ' 0px 6px 0px -2px cornflowerblue inset' : '0px -6px 0px -2px cornflowerblue inset',
+    )
 
     // update hovered component
     if (component.isEqualNode(hoveredComponent)) return
@@ -320,15 +322,15 @@ function Editor({ standaloneServer = false }) {
   const removeBorders = () => {
     const components = getComponents()
     components.forEach((c: HTMLDivElement) => {
-      c.style.setProperty('border-top', '')
-      c.style.setProperty('border-bottom', '')
+      c.style.setProperty('box-shadow', '')
     })
   }
 
-  // NOTE this trigger more times than it should
-  const onCanvasDragLeave = () => {
-    setHoveredComponent(null)
-    removeBorders()
+  const onCanvasDragLeave = (e: React.DragEvent<HTMLElement>) => {
+    if (!canvasRef.current?.contains(e.target as HTMLElement)) {
+      setHoveredComponent(null)
+      removeBorders()
+    }
   }
 
   const getComponents = (): HTMLDivElement[] => {