Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

add config ui #174

Merged
merged 1 commit into from
Jan 21, 2024
Merged

add config ui #174

merged 1 commit into from
Jan 21, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Nov 9, 2022

Description

  • adds a configuration ui available at /settings
  • adds an alert placeholder container to display alert messages

Todo:

  • add data validation (Parsley)
  • improve sidebar
  • add locked settings (not changeable from UI)
  • save the options
  • add tests
    • config.on_change_tray_toggle
    • config.convert_config
    • tray_icon.tray_run_threaded
    • tray_icon.tray_toggle
    • webapp.settings
    • webapp.api_settings
  • update tests
    • tray_icon.tray_end

Future improvements:

  • hide/show advanced/beta settings
  • mask/unmask sensitive settings (passwords, api keys, etc.)
  • browse button for selecting a file or directory
  • refresh web ui if specific settings change

Screenshot

image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 90 days with no activity. Remove the stale label or comment, otherwise this will be closed in 10 days.

@github-actions github-actions bot added the stale label May 14, 2023
@ReenigneArcher ReenigneArcher force-pushed the add/config-ui branch 14 times, most recently from ab4a38b to 152e92d Compare May 28, 2023 15:24
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 90 days with no activity. Remove the stale label or comment, otherwise this will be closed in 10 days.

@github-actions github-actions bot added the stale label Aug 27, 2023
@LizardByte-bot
Copy link
Member

⚠️ Qodana is checking this PR ⚠️
Live results available here

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (7715f94) 73.11% compared to head (6281b67) 73.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   73.11%   73.94%   +0.83%     
==========================================
  Files          10       10              
  Lines         796      902     +106     
==========================================
+ Hits          582      667      +85     
- Misses        214      235      +21     
Flag Coverage Δ
Linux-x64 69.51% <66.16%> (-1.98%) ⬇️
Windows-x64 73.17% <78.94%> (+1.93%) ⬆️
Windows-x86 73.17% <78.94%> (+1.93%) ⬆️
macOS-x64 73.39% <78.94%> (+1.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyra/definitions.py 82.92% <100.00%> (ø)
pyra/logger.py 61.03% <100.00%> (+1.31%) ⬆️
pyra/config.py 84.09% <97.77%> (+9.58%) ⬆️
pyra/tray_icon.py 83.03% <86.95%> (+4.68%) ⬆️
pyra/webapp.py 75.49% <58.62%> (-22.51%) ⬇️

pyra/webapp.py Fixed Show fixed Hide fixed
@ReenigneArcher ReenigneArcher force-pushed the add/config-ui branch 2 times, most recently from be7b988 to e09e934 Compare January 21, 2024 00:05
pyra/webapp.py Fixed Show fixed Hide fixed
@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 21, 2024 00:19
@ReenigneArcher ReenigneArcher merged commit fc04900 into master Jan 21, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the add/config-ui branch January 21, 2024 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants