Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(macos): statically link macos #1698

Closed
wants to merge 1 commit into from

Conversation

ReenigneArcher
Copy link
Member

Description

Removes dylib files before building Sunshine.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Oct 3, 2023

⚠️ Qodana is checking this PR ⚠️
Live results available here

@ReenigneArcher ReenigneArcher force-pushed the ci(macos)-statically-link-macos branch from ce019f5 to a0c5735 Compare October 3, 2023 23:14
@ReenigneArcher
Copy link
Member Author

Unsuccessful.

@ReenigneArcher ReenigneArcher reopened this Oct 3, 2023
@ReenigneArcher ReenigneArcher force-pushed the ci(macos)-statically-link-macos branch 7 times, most recently from 4f8622c to 3f53d69 Compare October 4, 2023 03:12
@ReenigneArcher ReenigneArcher force-pushed the ci(macos)-statically-link-macos branch from 3f53d69 to 19c105d Compare October 4, 2023 22:36
@ReenigneArcher ReenigneArcher marked this pull request as draft October 4, 2023 23:11
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Oct 4, 2023
@ReenigneArcher ReenigneArcher deleted the ci(macos)-statically-link-macos branch January 6, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve MacOS packaging
2 participants