fix(ui): reorder and add missing config options #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
commented
Jan 6, 2024
| @@ -189,21 +108,50 @@ <h1 class="my-4">Configuration</h1> | |||
| </tr> | |||
| </tbody> | |||
| </table> | |||
| <button class="mt-2 btn btn-success" style="margin: 0 auto" @click="add_global_prep_cmd"> | |||
| <button class="ms-0 mt-2 btn btn-success" style="margin: 0 auto" @click="add_global_prep_cmd"> | |||
There was a problem hiding this comment.
Button looked odd in the center, so moved it to left side.
| <div class="mb-3" v-if="platform === 'windows'"> | ||
| <label for="adapter_name" class="form-label">Adapter Name</label> | ||
| <input type="text" class="form-control" id="adapter_name" placeholder="Radeon RX 580 Series" | ||
| v-model="config.adapter_name" /> | ||
| <div class="form-text" v-if="platform === 'windows'"> |
There was a problem hiding this comment.
v-if not needed here, since parent div already has it.
Comment on lines
+456
to
+468
| <div class="mb-3" v-if="platform === 'linux'"> | ||
| <label for="adapter_name" class="form-label">Adapter Name</label> | ||
| <input class="form-control" id="adapter_name" placeholder="/dev/dri/renderD128" v-model="config.adapter_name" /> | ||
| <div class="form-text"> | ||
| Manually specify a GPU to use for capture.<br> | ||
| <pre>ls /dev/dri/renderD* # to find all devices capable of VAAPI</pre> | ||
| <pre> | ||
| vainfo --display drm --device /dev/dri/renderD129 | \ | ||
| grep -E "((VAProfileH264High|VAProfileHEVCMain|VAProfileHEVCMain10).*VAEntrypointEncSlice)|Driver version" | ||
| </pre> | ||
| Replace ``renderD129`` with the device from above to lists the name and capabilities of the device.<br> | ||
| To be supported by Sunshine, it needs to have at the very minimum: | ||
| <i>VAProfileH264High : VAEntrypointEncSlice</i> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
This was on the va-api tab previously, and it was the only option there. I thought it made more sense to put on the A/V tab... and not sure it applies to only va-api anyway?
| <div v-if="currentTab === 'advanced'" class="config-page"> | ||
| <!--Address family--> | ||
|
|
||
| <!-- Network Tab --> |
There was a problem hiding this comment.
Added new Network tab.
|
|
||
| <!-- Advanced Tab --> | ||
| <div v-if="currentTab === 'advanced'" class="config-page"> | ||
| <!-- Channels --> |
There was a problem hiding this comment.
setting was re-added
| </div> | ||
| </div> | ||
|
|
||
| <!-- HEVC Support --> |
There was a problem hiding this comment.
setting was re-added
| </div> | ||
| </div> | ||
|
|
||
| <!-- AV1 Support --> |
There was a problem hiding this comment.
setting was re-added
| </div> | ||
| </div> | ||
|
|
||
| <!-- Capture --> |
There was a problem hiding this comment.
setting was re-added
| </div> | ||
| </div> | ||
|
|
||
| <!-- Encoder --> |
There was a problem hiding this comment.
setting was re-added
| @@ -846,7 +1023,49 @@ <h2 class="accordion-header"> | |||
| </select> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <!-- Software Encoder Tab --> | |||
There was a problem hiding this comment.
Moved to end, like shown in the display
TheElixZammuto
approved these changes
Jan 7, 2024
make some options appear depending on the value of others
ReenigneArcher
force-pushed
the
fix(ui)-reorder-and-add-missing-config-options
branch
from
0591cfd to
22604cb
Compare
ReenigneArcher
deleted the
fix(ui)-reorder-and-add-missing-config-options
branch
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
e-dong
pushed a commit
to e-dong/Sunshine
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adapter_nameoption on A/V tabTodo:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.