win: amf: HRD blacklist, expand UI docs and various fixes. #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psyke83
force-pushed
the
hrd_fallback
branch
5 times, most recently
from
cf75c09 to
ab28277
Compare
psyke83
force-pushed
the
hrd_fallback
branch
2 times, most recently
from
9df8d33 to
f1b4b44
Compare
|
Did we break Polaris cards with #2251? |
|
Most likely, yes; a user on the Moonlight Discord's Sunshine channel reported artifacting on RX 580, and my RX 570 throttled the encoder to 30fps when I tested HRD several years ago. I'm not aware of any other reports so far. I'm not sure where to get a full list of Polaris cards, but the same encoder (VCE 3.4) seems to mostly consist of the RX 400 and RX 500 range. |
psyke83
commented
Apr 11, 2024
psyke83
force-pushed
the
hrd_fallback
branch
2 times, most recently
from
61940e3 to
5ab374f
Compare
Here's the list of Polaris device IDs I got from their driver INF |
* Add 'auto' default setting to 'rc_mode' and 'enforce_hrd' which defaults to 'cbr' and 'true', respectively. * Implement HRD blacklist: if a device ID matches, 'rc_mode' and 'enforce_hrd' are set to 'vbr_latency' and 'false' when set to 'auto'. The current blacklist applies to most RX 400 and RX 500 series, but can be expanded. * Document all new and existing AMF options in the docs and UI. Rearrange AMF options to better reflect importance (Usage is primary) and group by relatedness (RC and HRD influece each other's functionality), and group quality-related sub options. * Various cleanups & fixes to AMF option parsing, including proper setting of defaults if when invalid configuration is parsed.
Thanks, I've incorporated your list into the latest push. Should be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 'auto' default setting to 'rc_mode' and 'enforce_hrd' which defaults
to 'cbr' and 'true', respectively.
Implement HRD blacklist: if a device ID matches, 'rc_mode' and 'enforce_hrd'
are set to 'vbr_latency' and 'false' when set to 'auto'. The current
blacklist applies to the Polaris 10, 11 & 12 device ids (thanks to @cgutman).
Document all new and existing AMF options in the docs and UI. Rearrange
AMF options to better reflect importance. Usage is the base encoder preset;
group RC and HRD settings into rate control group, all others into Quality group.
Various cleanups & fixes to AMF option parsing, including proper setting of
defaults when invalid configuration is parsed.
Screenshot
Issues Fixed or Closed
Resolves some regressions for certain users in #2251
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.