fix(macos): properly handle accessibility permission #2508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2508 +/- ##
=========================================
- Coverage 11.17% 7.88% -3.29%
=========================================
Files 100 90 -10
Lines 17310 15803 -1507
Branches 8069 7487 -582
=========================================
- Hits 1934 1246 -688
+ Misses 12671 12131 -540
+ Partials 2705 2426 -279
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Needs test coverage on the new methods |
|
If we are going to test this, this has to be tested only on CI, this cannot be tested on macports test action. |
Hazer
force-pushed
the
fix/macos-accessibility-request
branch
from
2340497 to
062d1fb
Compare
|
Waiting for #2550 to create the tests |
Hazer
force-pushed
the
fix/macos-accessibility-request
branch
from
062d1fb to
c24e808
Compare
|
This needs to be updated and tested on macOS Sequoia before merging. |
Hazer
force-pushed
the
fix/macos-accessibility-request
branch
3 times, most recently
from
d8d4ada to
96505cc
Compare
|
Revisiting this PR, fixing conflicts first to get this on track |
|
Should I include a manual request in the web ui? Or the status saying whether the permission is given or not? @ReenigneArcher |
This sounds like a good idea... should it be a separate PR? |
|
@ReenigneArcher not sure. I may do it in the same, so I can improve the API around it once, cause it may change where it is declared, and as I have some code quality issues to review, I may do it in a single pass |
Hazer
force-pushed
the
fix/macos-accessibility-request
branch
from
96505cc to
915c7bf
Compare
Hazer
force-pushed
the
fix/macos-accessibility-request
branch
from
915c7bf to
a2e3b24
Compare
|
| #include "misc.h" | ||
| #include "permissions_manager.h" |
There was a problem hiding this comment.
| #include "misc.h" | |
| #include "permissions_manager.h" | |
| #include "src/platform/macos/misc.h" | |
| #include "src/platform/macos/permissions_manager.h" |
Should we be more explicit?
| #include <Carbon/Carbon.h> | ||
|
|
There was a problem hiding this comment.
| #include <Carbon/Carbon.h> | |
| #include <Carbon/Carbon.h> |
| // Even though the following two functions are available starting in macOS 10.15, they weren't | ||
| // actually in the Mac SDK until Xcode 12.2, the first to include the SDK for macOS 11 | ||
| #if __MAC_OS_X_VERSION_MAX_ALLOWED < 110000 // __MAC_11_0 | ||
| // If they're not in the SDK then we can use our own function definitions. |
There was a problem hiding this comment.
We can probably drop this, our readme lists macOS 13+. Although I don't have a strong opinion on this if we want to keep it as is.
There was a problem hiding this comment.
I haven't paid enough attention to it, yeah I'll remove it.
Description
Check for macOS Accessibility permission to allow mouse and keyboard input events to work properly.
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.