Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump third-party/build-deps from 1977d9c to 79c5243 #3275

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 8, 2024

Bumps third-party/build-deps from 1977d9c to 79c5243.

Commits
  • 79c5243 Commit 24c4175963f555c3e1bc589cdc628a1e6122c77c
  • 458f655 Commit 6cd5d50b3257b2fc1800dc11288d45f4705160db
  • faf1802 Commit f2a2ecc68a67cde784fb07c6af1e30b36b2e5f74
  • 67bf6e1 Commit 7828ffdaf84ac66b86947400a7c1669040303fc4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Oct 8, 2024
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) October 8, 2024 23:41
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.75%. Comparing base (e074316) to head (d4705a2).
Report is 85 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3275      +/-   ##
=========================================
+ Coverage    9.74%   9.75%   +0.01%     
=========================================
  Files         101     101              
  Lines       17975   17977       +2     
  Branches     8420    8420              
=========================================
+ Hits         1751    1753       +2     
+ Misses      13480   13477       -3     
- Partials     2744    2747       +3     
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.10% <ø> (ø)
macOS-13 10.56% <100.00%> (+<0.01%) ⬆️
macOS-14 10.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.cpp 4.56% <100.00%> (+0.32%) ⬆️

... and 3 files with indirect coverage changes

@ReenigneArcher ReenigneArcher added this to the stable release milestone Oct 9, 2024
@ReenigneArcher

This comment was marked as resolved.

@cgutman cgutman force-pushed the dependabot/submodules/third-party/build-deps-79c5243 branch from 7ee48a6 to 1cff800 Compare October 10, 2024 05:32
@cgutman
Copy link
Collaborator

cgutman commented Oct 10, 2024

I think we're just down to some Doxygen errors. I guess we probably should exclude all third_party directories from Doxygen.

@ReenigneArcher
Copy link
Member

Weird that it works in some builds. Can you try removing this line?

INCLUDE_PATH = ../third-party/build-deps/ffmpeg/Linux-x86_64/include/

I think I had to add that to get things working when we were using Sphinx and Breahte. Hopefully it's not needed.

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Oct 11, 2024

Weird that it works in some builds. Can you try removing this line?

INCLUDE_PATH = ../third-party/build-deps/ffmpeg/Linux-x86_64/include/

I think I had to add that to get things working when we were using Sphinx and Breahte. Hopefully it's not needed.

Seems to work: #3286 ... I will merge and rebase this one.

@ReenigneArcher ReenigneArcher force-pushed the dependabot/submodules/third-party/build-deps-79c5243 branch from 1cff800 to 87f0379 Compare October 11, 2024 00:48
@ReenigneArcher
Copy link
Member

I think it's closer, but now getting this:

Preprocessing /home/docs/checkouts/readt/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/3275/src/config.cpp:107: error: include file AMF/components/VideoEncoderAV1.h not found, perhaps you forgot to add its directory to INCLUDE_PATH?
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/3275/src/config.cpp:108: error: include file AMF/components/VideoEncoderHEVC.h not found, perhaps you forgot to add its directory to INCLUDE_PATH?
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/3275/src/config.cpp:109: error: include file AMF/components/VideoEncoderVCE.h not found, perhaps you forgot to add its directory to INCLUDE_PATH?
hedocs.org/user_builds/sunshinestream/checkouts/3275/src/config.cpp...

@ReenigneArcher ReenigneArcher force-pushed the dependabot/submodules/third-party/build-deps-79c5243 branch 3 times, most recently from 57d85db to 8d82f0c Compare October 11, 2024 02:50
@ReenigneArcher
Copy link
Member

Ended up putting the include path back in, as it seems to need it in this PR for some reason.

I think these couple of failures may somehow be related to the doxygen version. Arch and Brew are using 1.12. Ubuntu is < 1.10 for all distro versions.

Docs could be disabled for certain builds as a last resort.

@ReenigneArcher ReenigneArcher force-pushed the dependabot/submodules/third-party/build-deps-79c5243 branch 2 times, most recently from adf4a59 to 8d82f0c Compare October 11, 2024 20:48
dependabot bot and others added 3 commits October 11, 2024 22:36
Bumps [third-party/build-deps](https://github.com/LizardByte/build-deps) from `1977d9c` to `79c5243`.
- [Commits](LizardByte/build-deps@1977d9c...79c5243)

---
updated-dependencies:
- dependency-name: third-party/build-deps
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@ReenigneArcher ReenigneArcher force-pushed the dependabot/submodules/third-party/build-deps-79c5243 branch 2 times, most recently from 899faca to 78c6751 Compare October 12, 2024 02:41
@ReenigneArcher ReenigneArcher force-pushed the dependabot/submodules/third-party/build-deps-79c5243 branch from 78c6751 to d4705a2 Compare October 12, 2024 02:44
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
39 New issues
39 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 12, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/submodules/third-party/build-deps-79c5243 branch October 12, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants