feat(ddprobe): allow to manually specify gpu preference #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RebelliousX If you have time I have added a very stupid thing I would like to test regarding the ddprobe. Could you please try this build and see if it works (also with the ddprobe version that should supposedly fix the issue). That aside, I will soon add a manual override option and would also like you to test it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3521 +/- ##
=========================================
- Coverage 8.44% 8.44% -0.01%
=========================================
Files 90 90
Lines 16069 16074 +5
Branches 7633 7636 +3
=========================================
Hits 1357 1357
- Misses 14214 14218 +4
- Partials 498 499 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
changed the title
|
Sure thing, I am happy to test 😊 Using this PR's build installer, I didn't change the
Sunshine Log: GPU Preference is -1 (default)
Sunshine Log: GPU Preference is 0, works fine
Sunshine Log: GPU Preference is 1, not working
Sunshine Log: GPU Preference is 2, works fine |
# Conflicts: # src/platform/windows/display_base.cpp
|
@RebelliousX ty for the testing! @ReenigneArcher I have reverted the |
|
If I make a suggestion here too. The current WebUI is not really user friendly (or noob friendly). Instead of asking the user to run This can be done when And then parse the output text files for avaliable GPUs, Audio Outputs and Available Monitors too. The user shouldn't run these manually and should be able to select them from the WebUI. |
ReenigneArcher
approved these changes
Jan 8, 2025
|
|
@RebelliousX I think that can be considered in another PR. Can you add it as a feature request? https://github.com/orgs/LizardByte/discussions |
For screen we have this PR #2490 But it would be great to have it for everything if we have the possibility to have the information. |
I will, it was not my intention to go off topic, I thought it was related to this that is why I mentioned this here. 👍🏻 @FrogTheFrog I believe the default value should be The streaming will be okay on both monitors (the physical and the virtual one) and on both GPUs (the dGPU -in my case the Nvidia GTX 1050ti, or the iGPU Intel UHD 630). What I mean by this, everything is chosen automatically and working fine when the value is 0. If I specify the Virtual monitor (VDD which has dGPU attached to it) with UUID and leave Adapter Name empty, and default GPU preference is If I leave the The current default value of |
|
I personally have no opinion on this. It probably works because VDD by MTT allows you to specify GPU or who knows... @ReenigneArcher opinions on this? |
Yeah, I kind of agree, and it is hard for you to determine which is best since you don't have a hybrid GPU setup to test. But it seems value of 0 is safe. The current default value of -1 is defaulting to 1 according to the logs from above and causes problems. Edit: Also what do you think about a drop down menu instead with values:
But again, -1 and 1 are the same according to the logs 🤔 So actual valid values are { 0, 1, 2 }. |
|
I think the current numbering is correct.
It would be difficult to have a drop down value, because there's no limit to how high the number can technically go. |
10 tasks
cgutman
added a commit
to cgutman/LB_Sunshine
that referenced
this pull request
Jan 12, 2025
…rdByte#3521)" This reverts commit 6a233cb.
cgutman
added a commit
to cgutman/LB_Sunshine
that referenced
this pull request
Jan 12, 2025
…rdByte#3521)" This reverts commit 6a233cb.
qiin2333
pushed a commit
to qiin2333/Sunshine-Foundation
that referenced
this pull request
Jan 14, 2025
…aks DDA (LizardByte#3530) * Revert "feat(ddprobe): allow to manually specify gpu preference (LizardByte#3521)" This reverts commit 6a233cb. * Keep display revert delay input type change from 6a233cb * Remove ddprobe * feat(capture/windows): hook APIs to avoid output reparenting that breaks DDA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment
ddprobedoes not always work (see #3414). This PR allows to manually specify the GPU preference instead of relying on theddprobe.Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist