This repository has been archived by the owner on Oct 13, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Fix AlertListener on IPv6-aware hosts and prevent YoutubeDL from making the plugin hang #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
suggested changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There's a simpler way to use the plugin logger.
Can you think of some way to force/test this exception situation?
Co-authored-by: ReenigneArcher <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## nightly #196 +/- ##
===========================================
+ Coverage 68.97% 69.22% +0.24%
===========================================
Files 10 10
Lines 735 744 +9
===========================================
+ Hits 507 515 +8
- Misses 228 229 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
localhost
resolves to::1
. Thewebsocket
module used here expects anAF_INET
address, so it expectedly crashes when passed an IPv6 address such as::1
. The default URL used for reaching Plex is modified to127.0.0.1
to prevent this.outmpl
->outtmpl
)Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.