Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

Fix AlertListener on IPv6-aware hosts #201

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

zdimension
Copy link
Collaborator

Description

  • on many Linux machines, localhost resolves to ::1. The websocket module used here expects an AF_INET address, so it expectedly crashes when passed an IPv6 address such as ::1. The default URL used for reaching Plex is modified to 127.0.0.1 to prevent this.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #201 (8a58d71) into nightly (15099a5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly     #201   +/-   ##
========================================
  Coverage    68.97%   68.97%           
========================================
  Files           10       10           
  Lines          735      735           
========================================
  Hits           507      507           
  Misses         228      228           
Flag Coverage Δ
Linux 68.97% <100.00%> (ø)
Windows 68.97% <100.00%> (+3.26%) ⬆️
macOS 27.75% <100.00%> (-41.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/plex_api_helper.py 53.28% <100.00%> (ø)

@ReenigneArcher ReenigneArcher merged commit a1e1847 into LizardByte:nightly Nov 7, 2023
22 of 23 checks passed
@zdimension zdimension deleted the fix-ipv6-hang branch November 7, 2023 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlertListener does not work with some hosts on Linux
2 participants