Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST schema config for Phone number field. #86

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

joostdekeijzer
Copy link
Contributor

Field needs a modified schema config (it's an object, not a string).

Fixes #69

It's an object, not a string.
@Log1x
Copy link
Owner

Log1x commented Jan 30, 2024

Hi, thanks for the PR.

Do you mind updating the code style to match the rest of the project as well as adding a docblock?

@joostdekeijzer
Copy link
Contributor Author

Hi,

Updated to the project coding style (as far as I could see at least ;) and added docblock.

@Log1x Log1x merged commit ad2ee7a into Log1x:master Jan 31, 2024
1 check passed
@joostdekeijzer joostdekeijzer deleted the fix-69 branch January 31, 2024 12:45
@joostdekeijzer
Copy link
Contributor Author

Is it possible to release a new version with this fix included?

@Log1x
Copy link
Owner

Log1x commented Aug 14, 2024

done! sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API - is not accepting phone number
2 participants