-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-517: Update submodule ref LGHA for issue/OSOE-517 merge queue support #635
Conversation
The PR is failing due to PowerShell issues: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/7074667646/job/19255965083?pr=635#step:3:14 |
Thank you - I corrected and pushed |
This pull request has merge conflicts. Please resolve those before requesting a review. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
Shouldn't this be merged? |
Yes, sorry I don't know how I skipped this. |
WalkthroughThe update indicates a shift in the version of a subproject referenced within the Lombiq GitHub Actions repository. The commit hash change suggests that the subproject has been updated to a newer snapshot, reflecting enhancements, bug fixes, or other modifications. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1 +1 @@ | |||
Subproject commit 9ed9eea88eed608db26ec1edfbe3eb6670c975d5 | |||
Subproject commit e97046f366b01fdd05dd33d1e828694628cec40b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit hashes e97046f366b01fdd05dd33d1e828694628cec40b
and 9ed9eea88eed608db26ec1edfbe3eb6670c975d5
referenced in the PR are not present in the dev
branch of the tools/Lombiq.GitHub.Actions
submodule repository. It is recommended to manually verify the existence of these commits and ensure they have been correctly pushed to the remote repository.
Analysis chain
The hunk is empty, indicating the change is in the submodule reference. Ensure the submodule update to commit e97046f366b01fdd05dd33d1e828694628cec40b
is correct and that it includes the intended features or fixes for issue OSOE-517.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the submodule update by checking out the specific commit and reviewing the changes.
cd tools/Lombiq.GitHub.Actions
git fetch
git checkout e97046f366b01fdd05dd33d1e828694628cec40b
# Optionally, list changes or compare with the previous commit if needed.
git diff 9ed9eea88eed608db26ec1edfbe3eb6670c975d5
Length of output: 496
Script:
#!/bin/bash
# Check if the commit hashes exist in the remote repository history.
cd tools/Lombiq.GitHub.Actions
git fetch --all
# Check for the existence of the new commit hash.
git rev-list --all | grep e97046f366b01fdd05dd33d1e828694628cec40b
# Check for the existence of the old commit hash.
git rev-list --all | grep 9ed9eea88eed608db26ec1edfbe3eb6670c975d5
Length of output: 188
Script:
#!/bin/bash
# Check the .gitmodules file to verify the submodule configuration.
cat .gitmodules
Length of output: 4022
Script:
#!/bin/bash
# List the most recent commits on the 'dev' branch of the submodule to check for the commit hashes.
cd tools/Lombiq.GitHub.Actions
git fetch origin dev
git log origin/dev --oneline -10
Length of output: 690
OSOE-517
Summary by CodeRabbit