-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-819: Updated submodule package references to sourcegenerators #727
Conversation
I get these errors still on this branch: Build log.txt @sarahelsaig you don't? |
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/Libraries/Lombiq.HelpfulLibraries
It works flawlessly on Rider and the
This happens in Lombiq.BaseTheme, Lombiq.HelpfulLibraries.Tests, and Lombiq.VueJs, so all three projects that actually use the source generator. Of course System.Text.Json is part of the .NET runtime and it does work outside of Visual Studio so I'm not sure what this could mean. Also fwiw I got this interesting IntelliSense-only warning only for Lombiq.BaseTheme, suggesting that the Lombiq.BaseTheme\package.json may have something malformed in it:
(but this may be a red herring, since it works fine outside of VS) |
Any news, @AydinE? It's a large issue that builds under VS is broken. If you can't fix this ASAP, then please revert all the changed in |
Removed the extra folder and updated references
This pull request has merge conflicts. Please resolve those before requesting a review. |
OSOE-819
Potentially fixes Lombiq/Helpful-Libraries#238 (comment)
@Piedone weirdly I can't seem to reproduce the situation from your comment even with a completely fresh clone of OSOCE, the builds and tests within the pipeline also all seem to not have any issues.
EDIT: It does seem like this time around the build did fail on this same issue: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/8373846561/job/22927800545?pr=727#step:6:162