Use GetCMListForConnect and allow WebSockets in default protocols #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Web Sockets as a default connection. Updated Tests Tidy up some useless null checks.
LossyDragon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace GetCMList with GetCMListForConnect for a list of Connection Managers
Allow WebSockets as a detault protocol connection
Update SmartCMServerList
Update tests with missing test methods
(also removed useless null checking in AsyncJob)
Checks 1402 off PR in #181
Checks 1420 off PR in #181
Checks 1422 off PR in #181
Checklist