fix: Avoid undefined variable when the body is empty

Lookyloo · Feb 25, 2024 · 5a21965 · 5a21965
1 parent 18f2f71
commit 5a21965
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 20 deletions.
diff --git a/playwrightcapture/capture.py b/playwrightcapture/capture.py
@@ -484,19 +484,16 @@ async def store_request(request: Request) -> None:
                 if response := await request.response():
                     if response.ok:
                         try:
-                            body = await response.body()
+                            if body := await response.body():
+                                try:
+                                    mimetype = from_string(body, mime=True)
+                                    if mimetype.startswith('image'):
+                                        self._requests[request.url] = body
+                                except PureError:
+                                    # unable to identify the mimetype
+                                    self.logger.debug(f'Unable to identify the mimetype for {request.url}')
                         except Exception as e:
                             self.logger.debug(f'Unable to get body for {request.url}: {e}')
-                        else:
-                            try:
-                                if body:
-                                    mimetype = from_string(body, mime=True)
-                            except PureError:
-                                # unable to identify the mimetype
-                                self.logger.debug(f'Unable to identify the mimetype for {request.url}')
-                            else:
-                                if mimetype.startswith('image'):
-                                    self._requests[request.url] = body
             except Exception as e:
                 self.logger.warning(f'Unable to store request: {e}')
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -30,7 +30,7 @@ pytz = {"version" = "^2024.1", python = "<3.9"}
 tzdata = "^2024.1"
 playwright-stealth = "^1.0.6"
 setuptools = "^69.1.1"
-puremagic = "^1.20"
+puremagic = "^1.21"
 
 [tool.poetry.extras]
 recaptcha = ["requests", "pydub", "SpeechRecognition"]
@@ -40,7 +40,7 @@ optional = true
 
 [tool.poetry.group.dev.dependencies]
 types-beautifulsoup4 = "^4.12.0.20240106"
-pytest = "^8.0.1"
+pytest = "^8.0.2"
 mypy = "^1.8.0"
 types-dateparser = "^1.1.4.20240106"
 types-requests = "^2.31.0.20240218"