-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #1192
Merged
Merged
Misc fixes #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 21, 2024
Still seeing some weird testing errors |
samuelbray32
approved these changes
Dec 4, 2024
edeno
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_djuser_name
error specificity #1175: Adds suggestion of fix tocommon_lab.py
REGEXP
restriction fails on empty list #1183,common_usage.py
: Only add external tables if there are files associated with the exportDLCModelSource
usesfetch1
when restricting by a secondary key #1105: Modifiesposition_dlc_model.DLCModelSource.insert_entry
to prompt user if there arefetch_nwb
assumes fetching table inherits the mixin #1185:dj_helper_fn.fetch_nwb
Check that query expression (a) is an instanced table, and (b) inherits the Mixin before settinglog_export
argSpyglassMixinPart
rejects restrictions of self on delete #1163:dj_mixin
- conditionally applies the restriction to self or masterChecklist:
CITATION.cff
alter
snippet for release notes.CHANGELOG.md
with PR number and description.