Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trusted publishing for releases #678

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Use trusted publishing for releases #678

merged 2 commits into from
Nov 7, 2023

Conversation

edeno
Copy link
Collaborator

@edeno edeno commented Nov 7, 2023 •
edited
Loading

Description

This PR updates the release action to use trusted publishing instead of github secrets. From this blog post:

This method can be used in automated environments and eliminates the need to use username/password combinations or manually generated API tokens to authenticate with PyPI when publishing.

This is recommended by PyPI.

I also added isort on save for vscode settings.

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md doesn't seem necessary here
  • I have added/edited docs/notebooks to reflect the changes

@edeno edeno requested a review from CBroz1 November 7, 2023 17:05
@edeno edeno changed the title Use trusted publishing for release Use trusted publishing for releases Nov 7, 2023
CBroz1
CBroz1 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates, @edeno

@CBroz1 CBroz1 merged commit 1e66ad4 into master Nov 7, 2023
9 checks passed
@CBroz1 CBroz1 deleted the Use-trusted-publishing-for-release branch November 7, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edeno @CBroz1