Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 41_Extracting_Clusterless_Waveform_Features.ipynb #814

Closed
wants to merge 1 commit into from

Conversation

MichaelCoulter
Copy link
Collaborator

added note about parameter for faster waveform extraction

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context. Please list issues fixed or closed by
This PR.

  • Fixes #000: How this PR fixes the issue
    • path/file.py: Description of the change
    • path/file.py: Description of the change
  • Fixes #000: How this PR fixes the issue
    • path/file.py: Description of the change
    • path/file.py: Description of the change

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

added note about parameter for faster waveform extraction
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1
Copy link
Member

CBroz1 commented Feb 2, 2024

Hi @MichaelCoulter - Thanks for PR'ing your edits. When I go to look at the diff, I see 'Invalid Notebook'. This is also true on your fork. This has happened to me a lot if I edit notebooks in a text view rather than in VSCode.

For small patch edits, if no db connection is required, I find it easier to make the edits directly in the browser.

@MichaelCoulter
Copy link
Collaborator Author

thanks for the heads up. i tried to make this change in the browser, but i maybe i messed up the formatting?

@MichaelCoulter
Copy link
Collaborator Author

MichaelCoulter commented Feb 2, 2024

im just trying to add this text to the markdown cell that starts at line 493:

Frank Lab NOTE: if you use parameter "ampl_10_jobs_v2" instead of "amplitude" waveform extraction will be 4x faster.

@CBroz1
Copy link
Member

CBroz1 commented Feb 7, 2024

I added this to #821

@CBroz1 CBroz1 closed this Feb 7, 2024
@edeno edeno deleted the MichaelCoulter-patch-2 branch February 8, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants