-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytests round 2 #851
Pytests round 2 #851
Conversation
from spyglass.linearization.merge import LinearizedPositionOutput | ||
from spyglass.position.position_merge import PositionOutput | ||
|
||
# must import common_position before LinOutput to avoid circular import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A byproduct of the V0 move is that LinearizedOutput
can't be imported before the deprecated items in common_position
. Not sure if it counts as a bug worth opening an issue for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is worth opening up an issue for. It's not really expected behavior and will cause confusion.
from spyglass.linearization.merge import LinearizedPositionOutput | ||
from spyglass.position.position_merge import PositionOutput | ||
|
||
# must import common_position before LinOutput to avoid circular import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is worth opening up an issue for. It's not really expected behavior and will cause confusion.
Seems good to go pending resolution of conflicts. |
Description
Adds coverage to pytests across
common
,lfp
,utils
Coverage report
CITATION.cff
CHANGELOG.md