Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spikeinterface version #852

Merged
merged 35 commits into from
Mar 7, 2024

Conversation

khl02007
Copy link
Collaborator

@khl02007 khl02007 commented Feb 27, 2024

Description

A more recent version of spikeinterface is required for some functionalities of the spike sorting v1 pipeline, such as get_sorting methods

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

khl02007 and others added 27 commits May 9, 2023 23:56
@khl02007 khl02007 requested a review from edeno February 27, 2024 09:17
@CBroz1
Copy link
Member

CBroz1 commented Feb 27, 2024

Thanks @khl02007! Could you add a note to the changelog about (a) the motivation for the min pin (e.g., 'need >99.1 for spikeinterface.get_sorting') and (b) the motivation for the max pin (e.g., 'possible issues with X >100')

@khl02007
Copy link
Collaborator Author

@CBroz1 I just did it. Could you take a look?

@edeno
Copy link
Collaborator

edeno commented Feb 28, 2024

I changed some things back to be compatible with the version we are currently using. How necessary is this upgrade?

CHANGELOG.md Outdated Show resolved Hide resolved
@khl02007
Copy link
Collaborator Author

@edeno what changes did you make? e.g. SpikeSorting.get_sorting didn't work with the old version.

@khl02007 khl02007 mentioned this pull request Mar 7, 2024
4 tasks
@edeno edeno requested a review from CBroz1 March 7, 2024 22:36
@edeno
Copy link
Collaborator

edeno commented Mar 7, 2024

@khl02007 can you resolve the conflicts?

@edeno edeno merged commit a689162 into LorenFrankLab:master Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants