Add replacement implementation stores for client mods that don't have specific functions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustOptimize
suggested changes
Feb 16, 2024
src/common/Webpack.ts
Outdated
| window.webpackChunkdiscord_app.push( | ||
| [[Symbol()], | ||
| {}, | ||
| (r: { c: any; }) => |
There was a problem hiding this comment.
Ah yes, very readable
There was a problem hiding this comment.
that's how every discord mod does it I guess
JustOptimize
suggested changes
Feb 16, 2024
Replugged uses Zerebos (BdApi) findInTree and I just remade it. Go me :3
JustOptimize
suggested changes
Feb 20, 2024
the red is sus
| } | ||
| // [key: string]: string, | ||
| } = {}; | ||
| for (const key in implementationStores) { |
JustOptimize
suggested changes
Feb 26, 2024
|
I think this is almost ready. Awaiting review now. |
JustOptimize
suggested changes
Jun 24, 2024
| tree: Tree, | ||
| searchFilter: TreeFilter, | ||
| args: { walkable?: string[]; ignore?: string[]; maxRecursion: number } = { maxRecursion: 100 }, | ||
| ): Tree | null | undefined { |
There was a problem hiding this comment.
is there an explaination on why u returing or null or undefined and not just undefined?
There was a problem hiding this comment.
I don't know, this isn't my code
oh my eyes finally can rest
JustOptimize
approved these changes
Jun 24, 2024
|
what? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of time of writing (15.02.2024) the code is really messy and I probably haven't seen worse in past 2 years