This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
music: add music directory backend #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
a team,
eikehein,
lahm86 and
walkawayy
and removed request for
a team
lahm86
reviewed
May 1, 2024
There was a problem hiding this comment.
Works perfectly.
I wonder though for the situation where a player has neither the audio nor music folders present, if we should just fail silently rather throwing an assertion error. OG allows for both to be missing, and TR1X also allows for a missing music folder.
This adds support to play both CDAudio single MP3 as well as loading individual tracks directly from a music directory.
Thanks – fixed this. |
lahm86
approved these changes
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to play both CDAudio single MP3 as well as loading individual tracks directly from a music directory.
game/music/music_main.cis just whatgame/music.cused to be, with the CDAudio code extracted to a separate backend.The benefit is that the support for CDAudio is now a lot more compatible with the TR1 way of music handling.
Related: LostArtefacts/libtrx#6