dragon: fix dragon reviving after the dagger is pulled

[walkawayy]

Resolves #1572.

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Fixed the dragon reviving itself after Lara removes the dagger in a 1 frame window.

Explanation:
Dragon_Collision:
item->frame_num - g_Anims[item->anim_num].frame_base <= DRAGON_ALMOST_LIVE // 100

Dragon_Control:

creature->flags++;
if (creature->flags == DRAGON_LIVE_TIME) { // 330
    dragon_front_item->goal_anim_state = DRAGON_ANIM_STOP;
}

if (creature->flags >= DRAGON_LIVE_TIME + DRAGON_ALMOST_LIVE) { // 330 + 100
    dragon_front_item->hit_points =
        g_Objects[O_DRAGON_FRONT].hit_points / 2;
}

So what was happening simultaneously was:

1. Dragon_Control runs and creature->flags increments to 430 which is >= DRAGON_LIVE_TIME + DRAGON_ALMOST_LIVE (330+100).
2. Dragon_Collision runs the same frame and item->frame_num - g_Anims[item->anim_num].frame_base is 100 which is <=DRAGON_ALMOST_LIVE (100) so M_PullDagger runs .

So, M_PullDagger runs, but that really only prepares the dragon for death by setting creature->flags = -1;. However, in Dragon_Control already, the hit points were reset to 300/2 because the creature->flags hit 430. So, the else... then if (dragon_front_item->hit_points <= 0) { block is no longer run which checks for if (creature->flags > -20) { when the dragon has no HP and kills the dragon.

So, the fix is to change in Dragon_Control:
if (creature->flags >= DRAGON_LIVE_TIME + DRAGON_ALMOST_LIVE) { // 330 + 100
to
if (creature->flags > DRAGON_LIVE_TIME + DRAGON_ALMOST_LIVE) { // 330 + 100
that way we don't lose 1 frame in the window to pull the dagger and kill the dragon. I cannot screenshot or capture video of the old DirectX SW rendered window for some reason.

[github-actions]

Download the built assets for this pull request:

• TR1X-4.5.1-107-ge60a201-linux.zip
• TR1X-4.5.1-107-ge60a201-win.zip
• TR1X-4.5.1-107-ge60a201-win-installer.zip
• TR2X-0.5-136-ge60a201-win.zip

[lahm86]

LGTM. Recording below catching the dagger on frame 100 and missing it on frame 101.

https://youtu.be/q0Bt4J_n-9Y

DLL with frame display attached too.
TR2X.zip