Skip to content

Commit

Permalink
refactor: Update clippy command in Makefile and build workflow
Browse files Browse the repository at this point in the history
Update the clippy command in the Makefile to use the --no-default-features flag and add the thorvg-v1 feature. Also, update the build workflow to remove the --all-features flag when running cargo clippy for dotlottie-rs and dotlottie-ffi.
  • Loading branch information
theashraf committed Dec 13, 2024
1 parent 9e16c74 commit 2158fd6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Lint
run: |
cargo clippy --manifest-path=./dotlottie-rs/Cargo.toml --all-targets --all-features -- -D clippy::print_stdout
cargo clippy --manifest-path=./dotlottie-ffi/Cargo.toml --all-targets --all-features -- -D clippy::print_stdout
cargo clippy --manifest-path=./dotlottie-rs/Cargo.toml --all-targets -- -D clippy::print_stdout
cargo clippy --manifest-path=./dotlottie-ffi/Cargo.toml --all-targets -- -D clippy::print_stdout
env:
RUSTFLAGS: "-Dwarnings"
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ define UNIFFI_BINDINGS_BUILD
rm -rf $(RUNTIME_FFI)/$(RUNTIME_FFI_UNIFFI_BINDINGS)/$(BINDINGS_LANGUAGE)
cargo run \
--manifest-path $(RUNTIME_FFI)/Cargo.toml \
--features=uniffi/cli \
--no-default-features \
--features=uniffi/cli,thorvg-v1 \
--bin uniffi-bindgen \
generate $(RUNTIME_FFI)/src/dotlottie_player.udl \
--language $(BINDINGS_LANGUAGE) \
Expand Down

0 comments on commit 2158fd6

Please sign in to comment.