Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minimum deployment version of the iOS and MacOSX targets #269

Merged
merged 3 commits into from
Dec 6, 2024
Merged

fix: minimum deployment version of the iOS and MacOSX targets #269

merged 3 commits into from
Dec 6, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Dec 6, 2024 •
edited
Loading

Changes:

  • Updated GitHub Actions to use the latest macOS version since macOS-12 has been deprecated.
  • Ensured that native dependencies, and dotLottie-rs are built for the same minimum OS version. This is a potential fix for the issue: Can't add package in XCode 15.1. dotlottie-ios#9

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6f01b01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf force-pushed the fix/apple-build-regression branch from 1c6528f to e47b00a Compare December 6, 2024 11:38
@theashraf theashraf changed the title Fix/apple build regression fix: minimum deployment version of the iOS and MacOSX targets Dec 6, 2024
@theashraf theashraf marked this pull request as ready for review December 6, 2024 11:38
@samuelOsborne samuelOsborne merged commit a05fff7 into main Dec 6, 2024
1 check passed
@samuelOsborne samuelOsborne deleted the fix/apple-build-regression branch December 6, 2024 14:02
@theashraf theashraf mentioned this pull request Dec 6, 2024
Closed
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelOsborne samuelOsborne samuelOsborne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theashraf @samuelOsborne