Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viewer): enable/disable dotLottie frame interpolation in perf-test page #430

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

theashraf
Copy link
Member

Description

Changes:

  • Added an option to enable or disable frame interpolation for DotLottie and DotLottieWorker instances on the performance test page.

This helps in observing the impact of frame interpolation on performance

Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: 0c3c099

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf self-assigned this Dec 14, 2024
@theashraf theashraf requested review from afsalz and Aidosmf December 14, 2024 12:47
Copy link
Contributor

github-actions bot commented Dec 14, 2024

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 53.02% (🎯 52%) 561 / 1058
🟢 Statements 51.94% (🎯 51%) 588 / 1132
🟢 Functions 52.38% (🎯 52%) 143 / 273
🟢 Branches 58.73% (🎯 58%) 390 / 664
File CoverageNo changed files found.
Generated in workflow #1590 for commit 0c3c099 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Dec 14, 2024

Coverage Report for @lottiefiles/dotlottie-wc (packages/wc)

Status Category Percentage Covered / Total
🟢 Lines 98.46% (🎯 98%) 64 / 65
🟢 Statements 98.52% (🎯 98%) 67 / 68
🟢 Functions 100% (🎯 100%) 10 / 10
🟢 Branches 94.64% (🎯 94%) 53 / 56
File CoverageNo changed files found.
Generated in workflow #1590 for commit 0c3c099 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Dec 14, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 38.29 KB (0%) 766 ms (0%) 2.4 s (+36.27% 🔺) 3.2 s
@lottiefiles/dotlottie-web WASM 400.03 KB (0%) 8.1 s (0%) 0 ms (+100% 🔺) 8.1 s
@lottiefiles/dotlottie-react 41.15 KB (0%) 824 ms (0%) 1.8 s (-32.63% 🔽) 2.6 s
@lottiefiles/dotlottie-vue 45.17 KB (0%) 904 ms (0%) 3 s (+31.43% 🔺) 3.9 s
@lottiefiles/dotlottie-wc 45.67 KB (0%) 914 ms (0%) 2.4 s (+100.23% 🔺) 3.3 s
@lottiefiles/dotlottie-svelte 45.76 KB (0%) 916 ms (0%) 1.5 s (-30.91% 🔽) 2.4 s
@lottiefiles/dotlottie-solid 44.64 KB (0%) 893 ms (0%) 2.1 s (+25.86% 🔺) 2.9 s

@theashraf theashraf force-pushed the chore/viewer-frame-interpolation branch from b00dd1f to 0c3c099 Compare December 17, 2024 02:12
Copy link
Contributor

Coverage Report for @lottiefiles/dotlottie-react (packages/react)

Status Category Percentage Covered / Total
🟢 Lines 97.4% (🎯 95%) 75 / 77
🟢 Statements 97.56% (🎯 95%) 80 / 82
🟢 Functions 100% (🎯 95%) 26 / 26
🟢 Branches 89.13% (🎯 89%) 41 / 46
File CoverageNo changed files found.
Generated in workflow #1590 for commit 0c3c099 by the Vitest Coverage Report Action

@theashraf theashraf merged commit ed7f0f7 into main Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants