Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add missing layout prop #433

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(react): add missing layout prop #433

merged 1 commit into from
Dec 18, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Dec 17, 2024

Description

fixes #431

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: f5d330b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottiefiles/dotlottie-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theashraf theashraf self-assigned this Dec 17, 2024
@theashraf theashraf requested a review from afsalz December 17, 2024 11:48
Copy link
Contributor

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 53.02% (🎯 52%) 561 / 1058
🟢 Statements 51.94% (🎯 51%) 588 / 1132
🟢 Functions 52.38% (🎯 52%) 143 / 273
🟢 Branches 58.73% (🎯 58%) 390 / 664
File CoverageNo changed files found.
Generated in workflow #1595 for commit f5d330b by the Vitest Coverage Report Action

Copy link
Contributor

Coverage Report for @lottiefiles/dotlottie-react (packages/react)

Status Category Percentage Covered / Total
🟢 Lines 97.46% (🎯 95%) 77 / 79
🟢 Statements 97.61% (🎯 95%) 82 / 84
🟢 Functions 100% (🎯 95%) 27 / 27
🟢 Branches 90% (🎯 89%) 45 / 50
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/base-dotlottie-react.tsx 97.26% 90% 100% 97.14% 174, 217
Generated in workflow #1595 for commit f5d330b by the Vitest Coverage Report Action

Copy link
Contributor

Coverage Report for @lottiefiles/dotlottie-wc (packages/wc)

Status Category Percentage Covered / Total
🟢 Lines 98.46% (🎯 98%) 64 / 65
🟢 Statements 98.52% (🎯 98%) 67 / 68
🟢 Functions 100% (🎯 100%) 10 / 10
🟢 Branches 94.64% (🎯 94%) 53 / 56
File CoverageNo changed files found.
Generated in workflow #1595 for commit f5d330b by the Vitest Coverage Report Action

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 38.29 KB (0%) 766 ms (0%) 884 ms (+12.33% 🔺) 1.7 s
@lottiefiles/dotlottie-web WASM 400.03 KB (0%) 8.1 s (0%) 0 ms (+100% 🔺) 8.1 s
@lottiefiles/dotlottie-react 41.22 KB (+0.18% 🔺) 825 ms (+0.18% 🔺) 849 ms (-13.57% 🔽) 1.7 s
@lottiefiles/dotlottie-vue 45.17 KB (0%) 904 ms (0%) 835 ms (+94.78% 🔺) 1.8 s
@lottiefiles/dotlottie-wc 45.67 KB (0%) 914 ms (0%) 972 ms (+90.78% 🔺) 1.9 s
@lottiefiles/dotlottie-svelte 45.76 KB (0%) 916 ms (0%) 1.6 s (+98.25% 🔺) 2.5 s
@lottiefiles/dotlottie-solid 44.64 KB (0%) 893 ms (0%) 660 ms (+2.05% 🔺) 1.6 s

@theashraf theashraf merged commit c388ed6 into main Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotlottie-react layout
2 participants