fix: Update styles.css (Addresses #1 ) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# DO NOT MERGE This needs more testing off of (Windows, Firefox, 24" widescreen). Mostly removes rules that were no-ops. Materially, gets rid of the redundant 1px border on `table, td` and replaces it with a 1px border between cells only. `table-collapse` makes it have (what I assume is) the intended effect. Looks like this: TODO
Cheezmeister
commented
Feb 14, 2024
| @@ -1,5 +1,6 @@ | |||
| /* styles.css */ | |||
| html { | |||
| // TODO: Set font-size in units of em (https://en.wikipedia.org/wiki/Em_(typography)) | |||
There was a problem hiding this comment.
I guess this should be a separate issue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This needs more testing on clients other than (Windows, Firefox, 24" widescreen).
Mostly removes rules that were no-ops.
Materially, gets rid of the redundant 1px border on
table, tdand replaces it with a 1px border between cells only.table-collapsemakes it have (what I assume is) the intended effect.Looks like this: