updated support for brew shop and resin room #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resin Room added to csv and config Brew Shop added to config
derrell
requested changes
May 5, 2024
Untitled-1.ipynb
Outdated
| @@ -0,0 +1,164 @@ | |||
| { | |||
There was a problem hiding this comment.
Adding a file called "Untitled"? Was this added accidentally, or does it simply need a more appropriate name?
newSync.py
Outdated
| # output_string += f"Contracts: {self.nexudus_contracts}" | ||
| # output_string += f"Contracts: {self.nexudus_contracts}" | ||
| # output_string += f"Contracts: {self.nexudus_contracts}" | ||
| # output_string += f"Contracts: {self.nexudus_contracts}" |
There was a problem hiding this comment.
5 identical commented lines. Suggest deleting all, or all but one of them.
newSync.py
Outdated
| logging.debug("Starting Main Loop") | ||
|
|
||
| now = datetime.datetime.now(datetime.timezone.utc) | ||
| next_run = now - datetime.timedelta(minutes=update_frequency) |
There was a problem hiding this comment.
should this be now + timedelta rather than minus? It looks like next_run will be less than now, creating an infinite loop at line 428 below...
|
Hey sorry, I walked @avianathema through this and I forgot we branched off @benihana77 s branch, so this PR includes those changes. I'll see if I can change the target branch, that should isolate the PR to the changes Avi actually made. |
derrell
reviewed
May 6, 2024
|
Thanks. |
added trailing empty line per derrell's change request.
derrell
approved these changes
May 6, 2024
Zambito1
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resin Room added to csv and config
Brew Shop added to config