Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InnerTube): Add ability to get individual community posts and community post comments #861

Merged
merged 3 commits into from
Jan 11, 2025
Merged

feat(InnerTube): Add ability to get individual community posts and community post comments #861

merged 3 commits into from
Jan 11, 2025

Conversation

ChunkyProgrammer
Copy link
Contributor

closes: #352

Tested with: FreeTubeApp/FreeTube#6491

absidue
absidue reviewed Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the naming conventions used in the rest of the project (have you been writing C# code recently? capital letters at the start of the method name and Async in the function names in the FreeTube PR are C# conventions)

src/Innertube.ts Outdated Show resolved Hide resolved
src/Innertube.ts Outdated Show resolved Hide resolved
@LuanRT LuanRT merged commit 360b29e into LuanRT:main Jan 11, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 11, 2025
Open
@ChunkyProgrammer ChunkyProgrammer deleted the add-ability-to-get-community-posts branch January 17, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue left review comments

@LuanRT LuanRT LuanRT approved these changes

Assignees
No one assigned
Labels
large-diff parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for community post comments
3 participants
@ChunkyProgrammer @LuanRT @absidue